Send Welcome Kits by Household #30
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous version of the resupply function would resupply participants even if they had zero previous swabs assigned to them simply because this zero swabs was below the threshold value. This change makes it explicit that participants should have some number of barcodes before being eligible for a resupply shipment.
As the Cascadia study was getting off the ground, we sent welcome kits to a participant if they were fully consented and enrolled even if the household wasn't. Now that the study is further along, this creates additional shipments that we can eliminate. This change only makes a participant eligible for a welcome shipment once their whole household is fully consented and enrolled, even if that participant was consented and enrolled before that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Cascadia study was getting off the ground, we sent welcome kits to a participant if
they were fully consented and enrolled even if the household wasn't. Now that the study is
further along, this creates additional shipments that we can eliminate. This change only
makes a participant eligible for a welcome shipment once their whole household is fully
consented and enrolled, even if that participant was consented and enrolled before that.
This change also includes a minor change to resupply logic, only making a participant eligible once they have been assigned barcodes.
Note that we don't need to merge this until we get approval from Zack. This change to study logic is planned but not yet desired.